fix: show hidden character ownership logs to staff#1438
Merged
itinerare merged 2 commits intolk-arpg:release/v3.0.0from Mar 9, 2026
Merged
fix: show hidden character ownership logs to staff#1438itinerare merged 2 commits intolk-arpg:release/v3.0.0from
itinerare merged 2 commits intolk-arpg:release/v3.0.0from
Conversation
itinerare
added
bug
itinerare
approved these changes
Mar 9, 2026
ScuffedNewt
approved these changes
Mar 9, 2026
itinerare
added
reviewed
Contributor
|
I'm clearly a bit late approving this, but I love this- I was thinking about how to pull this off myself recently, but due to (still?!?) being sick, haven't gotten to it.. glad to see it merged! I also am sure I would've never figured out to used the booted function.. since I still don't know what it does. XD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went about it this way because it prevents having to either a) use
Auth::user()->hasPower()on every single character row or b) fix something across multiple locations. (I love global scopes and whereRelation...)Also removed some checks that weren't needed given we already check for if character is deleted (aka null).