Skip to content

feat: user and character reward grants#1390

Open
ScuffedNewt wants to merge 3 commits intolk-arpg:developfrom
ScuffedNewt:feature/reward-grants
Open

feat: user and character reward grants#1390
ScuffedNewt wants to merge 3 commits intolk-arpg:developfrom
ScuffedNewt:feature/reward-grants

Conversation

@ScuffedNewt
Copy link
Copy Markdown
Contributor

image image image image

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Dec 29, 2025
@SpeedyD
Copy link
Copy Markdown
Contributor

SpeedyD commented Dec 30, 2025

I'm.. a little bit confused. Isn't this just ... item and currency grants but in a single page? 🤔

..Ah, and loot table grants, since that's also a recent addition..

Copy link
Copy Markdown
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been told that this is, in fact, a condensed rewarder, potentially replacing Currency Grant, Item Grant, Loot Table Grant.. (Award Grant? for those with the ext anyway)

It seems like a decent feature to me, and so I'm approving it. We can eventually remove the other grant features, I reckon.

@itinerare
Copy link
Copy Markdown
Member

Nah, we had a lengthy discussion to the effect of "that would cause problems elsewhere".

@SpeedyD
Copy link
Copy Markdown
Contributor

SpeedyD commented Jan 4, 2026

Nah, we had a lengthy discussion to the effect of "that would cause problems elsewhere".

Would it? I can't really imagine.. 🤔 Well, I also haven't looked into it that closely, so I guess I'll take your word for it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs review Pull requests that are pending community review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants