Merged
Conversation
Contributor
ScuffedNewt
commented
Jan 21, 2025
ScuffedNewt
commented
- Adds item search to rarities
- Adds ability for users to disable profile comments (& delete comments on their profile based on site setting)
- Adds require_email config setting
- Adds item search to rarities - Adds ability for users to disable profile comments (& delete comments on their profile based on site setting) - Adds require_email config setting
SpeedyD
suggested changes
Jan 21, 2025
Contributor
SpeedyD
left a comment
SpeedyD
left a comment
There was a problem hiding this comment.
I left two points up, I think one should be changed, and the other.. well, I guess I'd like an explanation for it.
I have no idea why you seem to consider the 'Mention This User' section is part of comments? Why would it be collapsed? If anything, once I'm done with #1097 it'll be up to administration if users are allowed to see that anyway..
itinerare
added
enhancement
SpeedyD
approved these changes
Jan 25, 2025
LostInProgres
approved these changes
Jan 27, 2025
itinerare
reviewed
Jan 28, 2025
Member
|
Good additions on the whole! Just get that typo fixed and I'll be happy to merge. |
itinerare
approved these changes
Jan 28, 2025
itinerare
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.