[WIP] UniFFI trial #750
Draft
[WIP] UniFFI trial #750
+7,492
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pblazej
reviewed
Oct 21, 2025
ladvoc
force-pushed
the
ladvoc/uniffi-trial
branch
from
48449a0 to
41bd64c
Compare
pblazej
reviewed
Nov 3, 2025
| pub struct Claims { | ||
| pub exp: u64, | ||
| pub iss: String, | ||
| pub nbf: u64, |
There was a problem hiding this comment.
[nitpick] can we use SystemTime instead?
Makes clear what comes from uniffi
Allows client to access the version specified in Cargo.toml
* Unverified token * CR: Names * CR: Test token
ladvoc
force-pushed
the
ladvoc/uniffi-trial
branch
from
a028a03 to
3faab50
Compare
|
The I'd also commit (local) cc @1egoman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.