Ensure FFI events are processed sequentially #547
Conversation
🦋 Changeset detectedLatest commit: 15a2fbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| return ev.message.case == 'publishTrack' && ev.message.value.asyncId == res.asyncId; | ||
| }); | ||
| try { | ||
| const cb = await FfiClient.instance.waitFor<PublishTrackCallback>((ev) => { |
There was a problem hiding this comment.
curiously, does FfiClient.instance.request guarantee that it will trigger a PublishTrackCallback later ?
There is no need to change it now, but just an idea, I wonder if it makes sense to do things like
- prepare a waiter
- roomEventLock.lock()
- FfiClient.instance.request
- waiter.setAsyncId(res.asyncId)
- waiter will wait with some timeout, like await waiter.wait({ timeoutMs: 50 }); // not sure if that will bring more flakiness or less here.
| if (ev.case == 'participantConnected') { | ||
| const participant = this.createRemoteParticipant(ev.value.info!); | ||
| this.remoteParticipants.set(participant.identity!, participant); | ||
| this.emit(RoomEvent.ParticipantConnected, participant); |
There was a problem hiding this comment.
I have some concerns on this emit event since it is fired under the lock, and I wonder if it is a better pattern if we do things like
const unlock = await this.roomEventLock.lock();
const toEmit: Array<() => void> = [];
try {
// Push all the emit events in sequence to the array
toEmit.push(...);
} finally {
unlock();
}
// Fire the emit events
for (const fire of toEmit) {
try {
fire(); // consider await fire() ? if we need them to be synchronous
} catch ...
}
it is a suggestion, no need to work on it if you think the emit events are safe anyway.
4 participants
For some actions (i.e. publishing + unpublishing a track) the local participant needs to acquire the processing lock to ensure any state updates are done before emitting other events on the room level.