Skip to content

Conversation

@chenghao-mou
Copy link
Contributor

Speech will wait for both authorization and user silence.

User silence is defined as:

  • VAD: not speaking
  • VAD: speaking but has raw_accumulated_silence

@chenghao-mou chenghao-mou requested a review from a team November 26, 2025 15:23
@theomonnom
Copy link
Member

theomonnom commented Nov 26, 2025

If the user is in a noisy environment, we may never trigger the speech? VAD is a very unstable signal

if ev.speech_duration >= self._session.options.min_interruption_duration:
self._interrupt_by_audio_activity()

if ev.speaking and ev.raw_accumulated_silence <= 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want a threshold of raw_accumulated_speech here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we definitely don't want it to be speaking between user words.

@longcw
Copy link
Contributor

longcw commented Nov 27, 2025

If the user is in a noisy environment, we may never trigger the speech? VAD is a very unstable signal

I think it's fine, if VAD has a lot of false positives in a noisy env, the agent speech will still be interrupted all the time even without this waiting mechanism. we can add an option to make the threshold configurable, maybe disabled by default right now.

@chenghao-mou
Copy link
Contributor Author

If the user is in a noisy environment, we may never trigger the speech? VAD is a very unstable signal

I think it's fine, if VAD has a lot of false positives in a noisy env, the agent speech will still be interrupted all the time even without this waiting mechanism. we can add an option to make the threshold configurable, maybe disabled by default right now.

How about min_response_silence: how long the user silence the agent should wait for before it can respond, which should be shorter than min_endpointing_delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants