-
Notifications
You must be signed in to change notification settings - Fork 2k
fix agent_turn and agent_speaking spans hierarchy & add agent_turn for tts_task #4100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oh right, it's because the speaking state is updated in |
| ) -> None: | ||
| from .agent import ModelSettings | ||
|
|
||
| turn_id = utils.shortuuid("agent_turn_") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be named generation_id instead?
fixed in this pr as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
Tested with false interruptions and session.say. Spans were created correctly.
| return self._id | ||
|
|
||
| @property | ||
| def generation_id(self) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this field private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, #4124

agent_turnis under theagent_sessionspanagent_speakingspan when false interruption happensagent_turnfor tts_taskexample: function call and paused agent speeches
