Comments on Agent SDK prototype #237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced than I thought...
… like the receive end
…on the root AgentSession
…owing up in agent starter app
…gentLocalParticipant
…wnstream tokens This also facilitates running room.prepareConnection in the constructor
…regator This makes createMessageAggregator much simpler / just a wrapper tying some events together
…essageAggregator`s
…can be used directly as event handlers
ie, this.emit("...", aggregator.upsert)
…g room fully disconnected This means that agentSession.disconnect() CAN be put in a useEffect cleanup function
…n agent session connect
…ttaches the aggregator on connect / disconnect
|
Linking the Swift PR livekit-examples/agent-starter-swift#29 |
|
Moving discussion over to #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS
This pull request exists so folks can leave comments on this agent sdk prototype I put together.