check typeof cm.hasFocus before calling to avoid uncaught TypeError#8
Open
Nagidrop wants to merge 3 commits into
Open
check typeof cm.hasFocus before calling to avoid uncaught TypeError#8Nagidrop wants to merge 3 commits into
typeof cm.hasFocus before calling to avoid uncaught TypeError#8Nagidrop wants to merge 3 commits into
Conversation
Nagidrop
changed the title
typeof cm.hasFocus before calling to avoid uncaught TypeError
- Add `cancelAnimationFrame` to safely kill the `requestAnimationFrame` loop during cleanup, preventing background spam when rapidly switching files. - Revert static `activeEditor` caching to evaluate dynamically inside the keydown event, fixing interaction bugs with split panes and workspaces. - Consolidate event and frame clearing into a single `cleanup()` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error by checking
typeof cm.hasFocusbefore invoking it, falling back to reading it as a boolean when it is not a function.Also fixes security vulnerabilities by the way.
Third commit is vibe-coded, aims to improve performance, feel free to exclude it.
Closes #7