chore: bump gcp_auth to 0.12.2 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of protoc used in v1 doesn't seem to exist anymore, as can be seen by a failing CI run: https://github.com/liufuyang/bigtable_rs/actions/runs/9357260352/job/25756593924 ``` Run arduino/setup-protoc@v1 Getting protoc version: v3.20.3 Downloading archive: https://github.com/protocolbuffers/protobuf/releases/download/v3.20.3/protoc-3.20.3-osx-aarch_64.zip Error: Error: Failed to download version v3.20.3: Error, Unexpected HTTP response: 404 - 404 ```
gcp_auth changed their AuthenticationManager API in djc/gcp_auth#108. gcp_auth::provider() now returns a Arc<dyn TokenProvider>, rather than a AuthenticationManager, and AuthenticationManager is gone. This updates references in bigtable_rs codebase to follow. Closes liufuyang#75.
flokli
commented
Jul 1, 2024
| project_id: &str, | ||
| instance_name: &str, | ||
| is_read_only: bool, | ||
| channel_size: usize, | ||
| timeout: Option<Duration>, | ||
| authentication_manager: AuthenticationManager, | ||
| token_provider: Arc<dyn TokenProvider>, |
There was a problem hiding this comment.
I could also become a bit more generic here, so we don't need to Arc::new on the call site, but i leave it up to you to decide.
|
Thanks, this looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcp_auth changed their AuthenticationManager API in djc/gcp_auth#108.
gcp_auth::provider() now returns a Arc,
rather than a AuthenticationManager, and AuthenticationManager is gone.
This updates references in bigtable_rs codebase to follow.
Closes #75.