feat(server): Add source NodeRunId field to WorkflowEvent object (#1175)

Enables users to trace down the source NodeRun for any given WorkflowEvent by indexing the `node_run_id` field.
littlehorse-enterprises · Dec 10, 2024 · e3e4e7b · e3e4e7b
1 parent e3bbe4a
commit e3e4e7b
Show file tree

Hide file tree

Showing 14 changed files with 355 additions and 54 deletions.
diff --git a/dashboard/src/app/[tenantId]/workflowEventDef/[name]/components/WorkflowEventDef.tsx b/dashboard/src/app/[tenantId]/workflowEventDef/[name]/components/WorkflowEventDef.tsx
@@ -96,9 +96,7 @@ export const WorkflowEventDef: FC<Props> = ({ spec }) => {
                             <LinkWithTenant
                               className="py-2 text-blue-500 hover:underline"
                               target="_blank"
-                              // TODO: Add node highlighting
-                              // href={`/wfRun/${concatWfRunIds(workflowEvent.id?.wfRunId!)}?threadRunNumber=${workflowEvent.threadRunNumber}&nodeRunName=${workflowEvent.nodeRunPosition}-${spec.id?.name}-WORKFLOW_EVENT`}
-                              href={`/wfRun/${concatWfRunIds(workflowEvent.id?.wfRunId!)}`}
+                              href={`/wfRun/${concatWfRunIds(workflowEvent.id?.wfRunId!)}?threadRunNumber=${workflowEvent.nodeRunId?.threadRunNumber}&nodeRunName=${workflowEvent.nodeRunId?.position}-throw-${spec.id?.name}-THROW_EVENT`}
                             >
                               {concatWfRunIds(workflowEvent.id?.wfRunId!)}
                             </LinkWithTenant>

diff --git a/docs/docs/08-api.md b/docs/docs/08-api.md
@@ -4033,6 +4033,7 @@ world.
 | `id` | | [WorkflowEventId](#workfloweventid) | The ID of the WorkflowEvent. Contains WfRunId and WorkflowEventDefId. |
 | `content` | | [VariableValue](#variablevalue) | The content of the WorkflowEvent. |
 | `created_at` | | google.protobuf.Timestamp | The time that the WorkflowEvent was created. |
+| `node_run_id` | | [NodeRunId](#noderunid) | The NodeRun with which the WorkflowEvent is associated. |
  <!-- end Fields -->
  <!-- end HasFields -->
 

diff --git a/schemas/littlehorse/workflow_event.proto b/schemas/littlehorse/workflow_event.proto
@@ -27,6 +27,9 @@ message WorkflowEvent {
 
   // The time that the WorkflowEvent was created.
   google.protobuf.Timestamp created_at = 3;
+
+  // The NodeRun with which the WorkflowEvent is associated.
+  NodeRunId node_run_id = 4;
 }
 
 // The WorkflowEventDef defines the blueprint for a WorkflowEvent.

diff --git a/sdk-go/lhproto/workflow_event.pb.go b/sdk-go/lhproto/workflow_event.pb.go