-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added changes for upgrading some of the binaries & Go-Version in Litmuschecker #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonsy13 <[email protected]>
Jonsy13
requested review from
uditgaurav,
ispeakc0de,
Adarshkumar14 and
neelanjan00
June 29, 2023 16:36
neelanjan00
previously approved these changes
Jun 29, 2023
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
gdsoumya
previously approved these changes
Jul 21, 2023
Signed-off-by: Jonsy13 <[email protected]>
uditgaurav
approved these changes
Jul 21, 2023
Adarshkumar14
approved these changes
Jul 21, 2023
ispeakc0de
reviewed
Jul 21, 2023
@@ -1,10 +1,10 @@ | |||
module github.com/litmuschaos/dns_interceptor | |||
|
|||
go 1.19 | |||
go 1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has cgo dependency - we can test the binary once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested -
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ go mod tidy
go: downloading github.com/miekg/dns v1.1.41
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading golang.org/x/sys v0.5.0
go: downloading github.com/stretchr/testify v1.7.0
go: downloading golang.org/x/net v0.7.0
go: downloading golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ go build
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ ls
README.md dns_interceptor go.mod go.sum main.go server
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ ./dns_interceptor
[INFO] No PID mentioned running in current ns
INFO[0000] DNS Interceptor Port port=53
INFO[0000] Upstream DNS Server server="127.0.0.53:53"
INFO[0000] Chaos Error Targets targets="[]"
INFO[0000] Chaos Spoof Map spoof_map="map[]"
FATA[0000] Failed to create Interceptor error="wrong chaos type for dns chaos"
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ cat go.mod
module github.com/litmuschaos/dns_interceptor
go 1.20
require (
github.com/miekg/dns v1.1.41
github.com/sirupsen/logrus v1.9.3
)
require (
golang.org/x/net v0.0.0-20220906165146-f3363e06e74c // indirect
golang.org/x/sys v0.5.0 // indirect
)
replace golang.org/x/net => golang.org/x/net v0.7.0
vedant_shrotria@qa-lci-vm-2:~/test-tools/custom/dns_interceptor$ go version
go version go1.20.3 linux/amd64
ispeakc0de
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: