Added SIGTERM signal handling for graceful shutdown of Litmus-Checker #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Jonsy13 <[email protected]>
Jonsy13
requested review from
gdsoumya,
ispeakc0de,
amityt,
imrajdas and
uditgaurav
ispeakc0de
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With Argo 3.4.x, Now when users aborts an Argo-Workflow, The wait container sends a SIGTERM signal to other containers for suspension of Argo-Workflow Pod. Without handling of SIGTERM, The Workflow Pods gets into ERROR state & terminates. There is no functionality wise issues, Abort does works as expected, These changes are made to make sure our litmus-checker doesn't go into error state & shuts down gracefully!
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: