Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: added makefile target for linting the code #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kartikaysaxena
Copy link
Contributor

@kartikaysaxena kartikaysaxena commented Feb 18, 2024

Part of #196, this is primarily for contributors to ensure their code doesn't have any linting issues and can conveniently check by running make format_and_lint, it will also ensure this issue doesn't repeat in the future.

We may also add this to documentation for contributors to run this before creating a PR.

@shivam-Purohit
Copy link
Contributor

hey, @kartikaysaxena the change is good but I think you misunderstood what i said. I wanted to automate the process when we commit. so before committing a check would run for ex. like fmt then we would further add more checks if necessary. This is still manual and does not solve the issue. We would use the gofmt -l to check if there are issues in formatting. No need to add a separate script.

@Nageshbansal
Copy link
Collaborator

@shivam-Purohit is it resolved by pre-commit hooks now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants