UX Changes in litmusctl using promptui library. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarthakJain26
requested changes
Sep 28, 2023
Signed-off-by: deep-poharkar <[email protected]>
Signed-off-by: deep-poharkar <[email protected]>
Signed-off-by: deep-poharkar <[email protected]>
Signed-off-by: deep-poharkar <[email protected]>
deep-poharkar
force-pushed
the
all-ux-changes
branch
from
d7ed7b8
to
95963b9
Compare
|
LGTM 🚀 |
SarthakJain26
approved these changes
Nov 10, 2023
Saranya-jena
requested changes
Nov 15, 2023
Signed-off-by: deep-poharkar <[email protected]>
deep-poharkar
force-pushed
the
all-ux-changes
branch
from
f8323e6
to
e8fd85d
Compare
SarthakJain26
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX Changes In litmusctl
setAccount : Added Interactive Prompts and Password Input Masking
useAccount : confirmation message
Used the PromptUI library to ask the user to enter the Project ID and Chaos Experiment ID so that it eliminates the need for manual checks and provides a more user-friendly experience. Also, asks the user "Are you sure you want to delete this Chaos Experiment? (y/n)," allowing the user to confirm or cancel the deletion.
Project and Experiment : Allows the user to select an output format (json, yaml, table) using “promptui.Select”. Also, implemented pagination inside get experiments so that we can get experiments in pages where the user can enter q to quit,
if outputFormat is table.
Prompt to select output format as either YAML or JSON.
Prompting the user to enter a project name and showing Error and confirmation message.
Added experiment ID and experiment-run ID flags inside get.