Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto completion for parameters values && args #149

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Vr00mm
Copy link
Member

@Vr00mm Vr00mm commented Aug 25, 2023

Add completion for parameters values.

--project-id, Fetch projects from instance.
--experiment-id, Fetch experiments from instance. (project-id flag need to be set)

image

--chaos-infra-id, Fetch infrasID from instance. (project-id flag need to be set)
--chaos-infra, Fetch infrasID from instance. (project-id flag need to be set)

image

--output, values are "json", "yaml"

image

--installation-mode, values are "cluster", "namespace"
--type, values are "cluster", "namespace"
--platform-name, values are "AWS", "GKE", "Openshift", "Rancher", "Others"
--chaos-infra-type, values are "external", "internal"

image

I added the completion for those parameters on all commands.

Add completion for args.

litmus describe|save chaos-experiment
image

I tested the completion on bash only.

For bash:

source <(litmusctl completion bash)

For others, check the cobra completion doc:

litmusctl completion --help

@Vr00mm Vr00mm changed the title Add completion for parameters values && args Add auto completion for parameters values && args Aug 25, 2023
Copy link
Collaborator

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changes! 🚀

deep-poharkar and others added 5 commits September 11, 2023 18:21
* fixed the compatibility matrix

Signed-off-by: deep-poharkar <[email protected]>

* fixed AuthResponse snake case to camelCase

Signed-off-by: deep-poharkar <[email protected]>

---------

Signed-off-by: deep-poharkar <[email protected]>
* Update Upgrade Command

Signed-off-by: nagesh bansal <[email protected]>

* Rename ops/ and types/agent_types.go

Signed-off-by: nagesh bansal <[email protected]>

* Add Usage_0.23.0.md link in Readme

Signed-off-by: nagesh bansal <[email protected]>

---------

Signed-off-by: nagesh bansal <[email protected]>
* Added changes for 0.24 release

Signed-off-by: Sarthak Jain <[email protected]>

* minor changes

Signed-off-by: Sarthak Jain <[email protected]>

---------

Signed-off-by: Sarthak Jain <[email protected]>
@SarthakJain26
Copy link
Collaborator

@Vr00mm , the PR looks good, can you please resolve the conflicts so that we can merge it

@SarthakJain26
Copy link
Collaborator

@Vr00mm have you tested the describe chaos-experiment command? It works with chaos experiment ID and project ID, and not with the chaos experiment name

@Vr00mm Vr00mm closed this Oct 17, 2023
@Vr00mm Vr00mm reopened this Oct 17, 2023
@Vr00mm
Copy link
Member Author

Vr00mm commented Oct 17, 2023

@Vr00mm , the PR looks good, can you please resolve the conflicts so that we can merge it

Hello, iam trying to do it today !

Signed-off-by: Rémi ZIOLKOWSKI <[email protected]>
@SarthakJain26
Copy link
Collaborator

@Vr00mm can you please sign the commits, we will not be able to merge it without that

@Vr00mm
Copy link
Member Author

Vr00mm commented Oct 27, 2023

Arf sorry, It was the merge from your repo to mine. Iam fixing it.

@Vr00mm
Copy link
Member Author

Vr00mm commented Oct 27, 2023

I dont know why we have this blocking @SarthakJain26 all 3 commits are signed:

image

Can we just re-run de pipeline ?

image

@SahilKr24
Copy link
Member

@Vr00mm Github is not showing that the commits are signed so we can't merge.

image

Maybe you can try interactive rebase to sign the older commits by running this command:

git rebase --exec 'git commit --amend --no-edit -n -S' -i 4a0faab9323813da895a49c1943ca23998ce08ba

where 4a0faab9323813da895a49c1943ca23998ce08ba is the last unsigned commit.

Signed-off-by: Rémi ZIOLKOWSKI <[email protected]>
@Vr00mm Vr00mm force-pushed the master branch 2 times, most recently from 30070a0 to 51e2f80 Compare October 27, 2023 12:34
@Vr00mm
Copy link
Member Author

Vr00mm commented Oct 27, 2023

Ok iam done for today, i fked the repo.
I check it later.

@Nageshbansal
Copy link
Collaborator

Hey @Vr00mm, Are you still working on this? Feel free to let us know if you need any help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants