Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image registry bug fix #4887

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Image registry bug fix #4887

merged 7 commits into from
Oct 7, 2024

Commits on Sep 16, 2024

  1. fix: fetch image registry data correctly in StudioOverviewView 

    Fixes an issue where the image registry data was not being fetched

Why:
Previously, the image registry data was not being fetched, even though ExperimentMetadata has a field ‘imageRegistry’. This change ensures that the form receives the correct image registry data.

How:
Added a check for loading state by disabling the ‘next’ button and assigned the fetched image registry data to a variable before form submission. This ensures the `values.imageRegistry` field is populated correctly.

Signed-off-by: Aditya Sridasyam <[email protected]>
    @aditya3103
    aditya3103 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2999587 View commit details
    Browse the repository at this point in the history

  2. fix: passed imageRegistry in kubernetesBlankCanvasTemplate 

    Fixes an issue where the image registry data was not being passed in the kubernetesBlankCanvasTemplate function

Why:
kubernetesBlankCanvasTemplate is expecting imageRegistry but never being passed, it is overridden always by default imageRegistry values.

Signed-off-by: Aditya Sridasyam <[email protected]>
    @aditya3103
    aditya3103 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fac5da6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Rectified import order 

    imported @utils before `./StudioOverview.module.scss`, rectified as per the frontend check pipeline error 

Signed-off-by: aditya3103 <[email protected]>
    @aditya3103
    aditya3103 authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5c565f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fixed max character limit warning - kubernetesBlankCanvasTemplate fun… 

    …ction

Signed-off-by: aditya3103 <[email protected]>
    @aditya3103
    aditya3103 authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7450226 View commit details
    Browse the repository at this point in the history

  2. Fixed max character limit & trailing comma warning 

    Signed-off-by: aditya3103 <[email protected]>
    @aditya3103
    aditya3103 authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d20be66 View commit details
    Browse the repository at this point in the history

  3. Fixed trailing comma warning - kubernetesBlankCanvasTemplate 

    Signed-off-by: Aditya Sridasyam <[email protected]>

Signed-off-by: aditya3103 <[email protected]>
    @aditya3103
    aditya3103 authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2035769 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'master' into image-registry-bug-fix

    @Saranya-jena
    Saranya-jena authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    50d3c6a View commit details
    Browse the repository at this point in the history