Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for delete/abort when experiment is stuck in Queued state #4738

Closed
wants to merge 1 commit into from

Conversation

Baalekshan
Copy link
Contributor

@Baalekshan Baalekshan commented Jun 29, 2024

Proposed changes

Fixes #4679
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Added support for delete/abort when the experiment is stuck in Queued state
image

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Saranya-jena
Copy link
Contributor

@Baalekshan can you resolve the conflicts?

@Baalekshan
Copy link
Contributor Author

@Saranya-jena Resolved 👍

@Jonsy13
Copy link
Contributor

Jonsy13 commented Aug 23, 2024

Hi @Baalekshan , This is expected as there can be cases where deletion of experiment will not handle stopping of chaos experiments. It will only delete Chaos Experiment but faults will still keep running. Actual solution would be abort the experiment before deletion.

We are closing this PR for now, feel free to open it!

@Jonsy13 Jonsy13 closed this Aug 23, 2024
@Baalekshan
Copy link
Contributor Author

Hi @Jonsy13, I will try to make the changes in this PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for deletion/abort when the Experiment is stuck in Queued state
4 participants