-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pre-commit.sh to check for unused strings in strings.en.yaml #4596
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: shruti2522 <[email protected]>
chaoscenter/web/.husky/pre-commit
Outdated
@@ -1,8 +1,9 @@ | |||
#!/bin/sh | |||
"$(dirname "$0")/_/husky.sh" | |||
|
|||
MATCH_PATH='chaoscenter/web/' | |||
echo "\033[0;31;1mYou can't commit directly to main branch\033[0m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this line correct? this will be printed for each pre-commit hook irrespective to the branch
chaoscenter/web/.husky/pre-commit
Outdated
@@ -1,8 +1,9 @@ | |||
#!/bin/sh | |||
"$(dirname "$0")/_/husky.sh" | |||
|
|||
MATCH_PATH='chaoscenter/web/' | |||
echo "\033[0;31;1mYou can't commit directly to main branch\033[0m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tested properly?
In Litmus there is no main branch, we have a master branch here. Please verify this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not changed the code for this, it is how the original implementation is in pre-commit.sh. Should I change it to master
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @shruti2522 that went unnoticed by me. Please change it to master.
Proposed changes
Fix #4550. Added pre-commit checks to look for unused strings in the strings.en.yaml file.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency