-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chaos-operator in chaoscenter/subscriber #4225
base: master
Are you sure you want to change the base?
Update Chaos-operator in chaoscenter/subscriber #4225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also pushed the api binary
@@ -65,6 +63,7 @@ replace ( | |||
github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503-38ab9da00309 | |||
|
|||
github.com/emicklei/go-restful => github.com/emicklei/go-restful v2.16.0+incompatible | |||
github.com/litmuschaos/chaos-operator => ../../../chaos-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using your local operator repo which isn't right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the discussion in contributor call, this will be updated later once operator pr is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to be merged: litmuschaos/chaos-operator#475
Signed-off-by: nagesh bansal <[email protected]>
6585346
to
7e5cd4c
Compare
This PR have to wait for the #475 to be merged. |
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: