Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for 3.0.0-beta8 ChaosCenter Release #4009

Merged
merged 5 commits into from
Jun 20, 2023

Conversation

Jonsy13
Copy link
Contributor

@Jonsy13 Jonsy13 commented Jun 19, 2023

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Copy link
Contributor

@SarthakJain26 SarthakJain26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amityt
Copy link
Contributor

amityt commented Jun 20, 2023

@namkyu1999 Can you check the test cases for github.com/litmuschaos/litmus/litmus-portal/graphql-server/pkg/rest_handlers
We are merging this PR for release, will take the test cases fix in a different PR.

@Jonsy13 Jonsy13 merged commit 1d15a8f into litmuschaos:master Jun 20, 2023
@Jonsy13 Jonsy13 deleted the 3.0.0-beta8-tracker branch June 20, 2023 06:52
@namkyu1999
Copy link
Member

@namkyu1999 Can you check the test cases for github.com/litmuschaos/litmus/litmus-portal/graphql-server/pkg/rest_handlers We are merging this PR for release, will take the test cases fix in a different PR.

I will fix test cases and make different PR @amityt :)

SohamRatnaparkhi pushed a commit to SohamRatnaparkhi/litmus that referenced this pull request Jun 20, 2023
* Added changes for 3.0.0-beta8 ChaosCenter

Signed-off-by: Jonsy13 <[email protected]>

* Fixed file_handlers test

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

---------

Signed-off-by: Jonsy13 <[email protected]>
SohamRatnaparkhi pushed a commit to SohamRatnaparkhi/litmus that referenced this pull request Jun 30, 2023
* Added changes for 3.0.0-beta8 ChaosCenter

Signed-off-by: Jonsy13 <[email protected]>

* Fixed file_handlers test

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

---------

Signed-off-by: Jonsy13 <[email protected]>
SohamRatnaparkhi pushed a commit to SohamRatnaparkhi/litmus that referenced this pull request Jun 30, 2023
* Added changes for 3.0.0-beta8 ChaosCenter

Signed-off-by: Jonsy13 <[email protected]>

* Fixed file_handlers test

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

* Added changes for 3.0.0-beta8

Signed-off-by: Jonsy13 <[email protected]>

---------

Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: SohamRatnaparkhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants