(analytics): Frontend updates for Application dashboard and data source CRUD v2 #2890
Conversation
Signed-off-by: ishangupta-ds <[email protected]>
Signed-off-by: ishangupta-ds <[email protected]>
…dashboards. Signed-off-by: ishangupta-ds <[email protected]>
ishangupta-ds
requested review from
whitetiger1399,
imrajdas,
Saranya-jena,
arkajyotiMukherjee,
vanshBhatia-A4k9 and
SarthakJain26
Signed-off-by: ishangupta-ds <[email protected]>
Signed-off-by: ishangupta-ds <[email protected]>
| export const copyTextToClipboard = (text: string) => { | ||
| if (!navigator.clipboard) { | ||
| console.error('Oops Could not copy text: '); | ||
| return; | ||
| } | ||
| navigator.clipboard | ||
| .writeText(text) | ||
| .catch((err) => console.error('Async: Could not copy text: ', err)); | ||
| }; |
There was a problem hiding this comment.
While this is a good change, we have been using this function to pass it the local state from a react component and base the copying state position from that, This was discussed earlier as well..I did not see this being used in this PR, have you tested its functionality?
There was a problem hiding this comment.
Its being used to copy the queries @vanshBhatia-A4k9
There was a problem hiding this comment.
Had tested it, will check again though ! Confirming shortly.
There was a problem hiding this comment.
Updated @vanshBhatia-A4k9
|
Also, Since the overview tab has changed entirely now, please update it here as well |
Signed-off-by: ishangupta-ds <[email protected]>
Signed-off-by: ishangupta-ds <[email protected]>
@rajdas98 on running the npm install command i am getting these changes, should i just revert to master and send without running it? |
Signed-off-by: ishangupta-ds <[email protected]>
Fixed using |
| import { ParsedPrometheusData } from '../models/dashboardsData'; | ||
| import { PromQuery } from '../models/graphql/dashboardsDetails'; | ||
| /* eslint-disable no-useless-escape */ | ||
| /* eslint-disable no-param-reassign */ |
There was a problem hiding this comment.
Can you remove the eslint disable commands if possible?
There was a problem hiding this comment.
no-useless-escape we need for the regex and no-param-reassign is done purposely as per the logic (its just a warning not an error for lint)
| @@ -0,0 +1,237 @@ | |||
| /* eslint-disable no-unused-expressions */ | |||
There was a problem hiding this comment.
Will try to but, can't remove this no-param-reassign as lint wants to return something on iterating but its not my use-case, its a kind of warning but we have purposely used the map/forEach this way. @Saranya-jena
|
@Saranya-jena i have removed as much disabled lint checks as possible but some are purposely placed. |
Proposed changes
Types of changes
Checklist
Dependency
Special notes for your reviewer:
App. dashboard (with data source) CRUD v2 PR #2