Image registry bug fix #4887
Open
Image registry bug fix #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the image registry data was not being fetched Why: Previously, the image registry data was not being fetched, even though ExperimentMetadata has a field ‘imageRegistry’. This change ensures that the form receives the correct image registry data. How: Added a check for loading state by disabling the ‘next’ button and assigned the fetched image registry data to a variable before form submission. This ensures the `values.imageRegistry` field is populated correctly. Signed-off-by: Aditya Sridasyam <[email protected]>
Fixes an issue where the image registry data was not being passed in the kubernetesBlankCanvasTemplate function Why: kubernetesBlankCanvasTemplate is expecting imageRegistry but never being passed, it is overridden always by default imageRegistry values. Signed-off-by: Aditya Sridasyam <[email protected]>
|
DCO is correctly signed, used my real name instead of GitHub username as per the CONTRIBUTING doc @namkyu1999 |
amityt
approved these changes
Sep 16, 2024
|
Thanks @aditya3103 for this PR , the github pipelines are running now. |
imported @utils before `./StudioOverview.module.scss`, rectified as per the frontend check pipeline error Signed-off-by: aditya3103 <[email protected]>
|
I have rectified the import order which was resulting in an error in the frontend build pipeline @imrajdas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Image Registry value was not being fetched and reflected in the chaos studio yaml section, it was always overriding and applying the default image registry values
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: