made remoteHub as required field

Signed-off-by: JanhaviAlekar <[email protected]>
litmuschaos · Sep 6, 2024 · eafda38 · eafda38
1 parent c2c07c0
commit eafda38
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 4 deletions.
diff --git a/chaoscenter/web/src/api/core/chaoshubs/addChaosHub.ts b/chaoscenter/web/src/api/core/chaoshubs/addChaosHub.ts
@@ -8,7 +8,7 @@ export interface CreateChaosHubRequest {
   description?: string;
   repoURL: string;
   repoBranch: string;
-  remoteHub?: string;
+  remoteHub: string;
   isPrivate: boolean;
   authType: AuthType;
   token?: string;

diff --git a/chaoscenter/web/src/strings/strings.en.yaml b/chaoscenter/web/src/strings/strings.en.yaml
@@ -909,6 +909,7 @@ referencedBy: Referenced By
 registry: Registry
 registryName: Registry Name
 registryType: Registry Type
+remoteHub: Select Remote hub
 remoteRepo: Remote Repository
 remove: Remove
 removeMember: Remove Member

diff --git a/chaoscenter/web/src/strings/types.ts b/chaoscenter/web/src/strings/types.ts
@@ -753,6 +753,7 @@ export interface StringsMap {
   'registry': unknown
   'registryName': unknown
   'registryType': unknown
+  'remoteHub': unknown
   'remoteRepo': unknown
   'remove': unknown
   'removeMember': unknown

diff --git a/chaoscenter/web/src/views/AddHubModalWizard/AddHubModalWizard.tsx b/chaoscenter/web/src/views/AddHubModalWizard/AddHubModalWizard.tsx
@@ -192,7 +192,8 @@ const GitConnectionStep: React.FC<
         }}
         validationSchema={Yup.object().shape({
           repoBranch: Yup.string().trim().required('Hub Branch name is a required field'),
-          repoURL: Yup.string().trim().required('Hub Repo name is a required field')
+          repoURL: Yup.string().trim().required('Hub Repo name is a required field'),
+          remoteHub: Yup.string().trim().required('Remote Hub name is a required field')
         })}
       >
         {formikProps => {
@@ -238,7 +239,7 @@ const GitConnectionStep: React.FC<
                 <FormInput.DropDown
                   name="remoteHub"
                   label={<Text font={{ variation: FontVariation.FORM_LABEL }}>Remote Hub</Text>}
-                  placeholder={'Select Remote hub'}
+                  placeholder={getString('remoteHub')}
                   items={[
                     { label: 'GitHub', value: 'GitHub' },
                     { label: 'Bitbucket', value: 'Bitbucket' },

diff --git a/chaoscenter/web/src/views/ChaosHubMenu/__tests__/ChoasHubMenu.test.tsx b/chaoscenter/web/src/views/ChaosHubMenu/__tests__/ChoasHubMenu.test.tsx
@@ -38,6 +38,7 @@ describe('ChaosHubMenuView Tests', () => {
       name: 'Test Hub',
       isDefault: false,
       repoURL: '',
+      remoteHub: '',
       repoBranch: '',
       projectID: '',
       authType: AuthType.SSH,

diff --git a/chaoscenter/web/src/views/ChaosHubs/ChaosHubs.tsx b/chaoscenter/web/src/views/ChaosHubs/ChaosHubs.tsx
@@ -68,7 +68,7 @@ const RemoteHubImage = ({ remoteHubName }: { remoteHubName: string }): React.Rea
     }
   };
 
-  return <>{hubSvg()}</>;
+  return hubSvg();
 };
 
 export const ChaosHubsView: React.FC<ChaosHubParams> = ({