Litmus Agent: allow using existing configuration and secrets #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambonbonne
requested review from
ksatchit,
imrajdas,
Jonsy13,
ispeakc0de and
Saranya-jena
as code owners
Jonsy13
approved these changes
Jun 7, 2024
Saranya-jena
approved these changes
Jun 7, 2024
SarthakJain26
approved these changes
Jun 7, 2024
|
Sorry, I didn't see that a check failed. I'll work on it next week. |
sambonbonne
force-pushed
the
feature/use-existing-secret-and-config
branch
6 times, most recently
from
5155d26
to
67ca59b
Compare
Signed-off-by: Sam <[email protected]>
sambonbonne
force-pushed
the
feature/use-existing-secret-and-config
branch
from
67ca59b
to
857d89f
Compare
|
I was using the latest version of helm-docs locally so I downgraded to use the same as CI. Also, the DCO bot was not happy by the name in the "Signed-off-by" so I updated it to comply with what it expected. Finally, I rebased my branch from master and updated the chart version again. I think the CI should be OK now, sorry for the delay! |
|
Hi Team, |
|
Thanks @sambonbonne for the contribution, Merging this PR now! |
|
Thanks @Jonsy13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using the Litmus Agent chart, we can set
global.infraConfigNameandglobal.infraSecretNamebut we can't use an existing (already in cluster) config or secret.Which issue this PR fixes
Special notes for your reviewer:
This is a rework of #313 with the addition of the ability to use an existing
ConfigMap.Checklist