Modify labels configuration for litmus-core #363
Conversation
- Create seperate set of labels/labelSelector for the operator and exporter - Include the app label in the common label in helper.tpl - Update the helper.tpl so the label management is closer to the sub-chart of litmus-agent (the selector label are included in the list of label) Signed-off-by: Calvin Audier <[email protected]>
Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
ksatchit,
Jasstkn,
ajeshbaby,
gdsoumya,
imrajdas and
ispeakc0de
as code owners
charts/litmus-core/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| appVersion: "2.14.0" | |||
| description: A Helm chart to install litmus infra components on Kubernetes | |||
| name: litmus-core | |||
| version: 2.14.1 | |||
| version: 2.14.2 | |||
There was a problem hiding this comment.
matchLabels changes are not backward compatibles
- Changed bump to 2.15.0 instead of 2.14.2 as per jouve comment - Regenerating docs with helm-docs Signed-off-by: Calvin Audier <[email protected]>
|
Hi guys |
|
Hi @Calvinaud , Can you please update the version to fix conflicts. |
| @@ -23,8 +22,7 @@ kind: ClusterRoleBinding | |||
| metadata: | |||
| name: {{ include "litmus.fullname" . }}-admin | |||
| labels: | |||
| app: {{ template "litmus.name" . }} | |||
| {{- include "litmus.labels" . | indent 4 }} | |||
| {{- include "litmus.operatorLabels" . | indent 4 }} | |||
There was a problem hiding this comment.
Why do we need the labels on clusterrole and clusterrolebinding?
There was a problem hiding this comment.
The labels were already present before this PR. Personally I still think that the labels are useful since it help to know at which application the clusterrole/clusterrolebinding are part of.
For the ****-admin, I think the question is more are they part of the "operator" but I would still said yes.
But if needed, I can remove them.
Bump version to 3.6.1 Signed-off-by: Calvin Audier <[email protected]>
Bump to version 3.7.1 Signed-off-by: Calvin Audier <[email protected]>
Signed-off-by: Calvin Audier <[email protected]>
Updated by bumping version to 3.7.1 |
What this PR does / why we need it:
Update the labels configuration so that the labels for operator and exporter are not the same. The goal was that the service doesn't match both the exporter and operator at the same time. Which is the setup in the chaos-exporter sub-chart of litmus-agent.
I tried to match the configuration of the sub-chart of litmus-agent.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]