feat(litmus): add pod annotations support #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itninja-hue
requested review from
imrajdas,
ispeakc0de and
Jasstkn
as code owners
itninja-hue
force-pushed
the
litmus/add_pod_annotations_support
branch
from
374f53b to
bc11c2f
Compare
|
This is a great add, need this as well. |
Signed-off-by: itninja-hue <[email protected]>
Signed-off-by: itninja-hue <[email protected]>
Signed-off-by: itninja-hue <[email protected]>
itninja-hue
force-pushed
the
litmus/add_pod_annotations_support
branch
from
2f300db to
66c3de8
Compare
|
@imrajdas @ispeakc0de hey. could you review this MR? |
itninja-hue
changed the title
itninja-hue
changed the title
|
Hi @itninja-hue Can you resolve the conflicts in this PR. |
Jonsy13
reviewed
Oct 4, 2022
f4tal-err0r
approved these changes
Oct 9, 2022
| @@ -26,6 +26,12 @@ spec: | |||
| {{- if .Values.portal.server.customLabels }} | |||
| {{ toYaml .Values.portal.server.customLabels | nindent 8 }} | |||
| {{- end }} | |||
| {{- if .Values.portal.server.podAnnotations }} | |||
| annotations: | |||
| {{- range $key, $value := .Values.portal.server.podAnnotations }} | |||
There was a problem hiding this comment.
@itninja-hue Please consider replacing this with:
{{- with .Values.portal.server.podAnnotations }}
{{ toYaml . | indent 8 }}
{{- end }}
This should result in the equivalent values yaml being:
[...]
portal:
server:
podAnnotations:
annotation: "example"
annotation.two: "example"
[...]
instead of being divided into two keys and is much easier.
Jonsy13
approved these changes
Oct 10, 2022
|
Hi @itninja-hue Can you resolve the conflicts in this PR. |
|
Hi @itninja-hue, Can you please update the branch. |
|
@itninja-hue Is this PR still active ? I'm interested by this PR and can work on it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add support for pod annotations
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]