Add security context for init container for portal server #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-harris
requested review from
imrajdas,
ispeakc0de and
Jasstkn
as code owners
Signed-off-by: Stephen Harris <[email protected]>
stephen-harris
force-pushed
the
feat/add-security-context-for-server-init-container
branch
from
d9f302b
to
dd70e79
Compare
Jasstkn
approved these changes
Mar 10, 2022
|
@stephen-harris Have you tested it. I think mongo won't run with these fields in the security context |
|
@rajdas98 Apologies for not replying sooner. Yes I have tested this. The change is for the |
|
@imrajdas hi. could you take a loot into this PR? |
|
@imrajdas hi. Can you evaluate if this is still something that we want to have? |
|
@Jasstkn - There is a merge conflict |
…container Signed-off-by: Maria Kotlyarevskaya <[email protected]>
|
@stephen-harris hi! do you want to continue working on this? I think that it's enough to make security context configurable. then users can decide if they want to configure it or not? |
3 tasks
|
No activity in this PR. I'm going to close it in favor of #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add's support for configuring the securityContext of the litmus-server init container. In environments where runAsNonRoot is automatically set to
truethe init container fails to start because therunAsUseris not specified.This also aligns the configuration of the init container with the other containers in this deployment.
Which issue this PR fixes
n/a
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]