Add security context for wait-for-mongodb #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add securityContext in values.yaml - Using this securityContext in auth-server-deployment.yaml and server-deployment.yaml - Bumping Chart version to 2.16.0 - Regenerating docs with helm-docs Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
imrajdas,
ispeakc0de and
Jasstkn
as code owners
|
I was not sure if this change needed to be considered as a bug fix (and bump to 2.15.11) or a added feature (and bump to 2.16.0). I can change if needed. |
|
Didn't see the PR, #212. Should I close this one in favor of the previous one ? |
|
Let me take a look. Will reply by EOD, thanks! |
3 tasks
Jasstkn
requested changes
Aug 29, 2023
Mentioned PR wasn't updated on requested, closed it in favor of yours. Please, let me know if you have any questions about the comments that I've left. |
- Update values.yaml to remove default values for security securityContext - Example values for securityContext as comments - Regenerating docs with helm-docs - Switching for bump to 2.16.0 to bump to 2.15.11 Signed-off-by: Calvin Audier <[email protected]>
Jasstkn
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
LGTM 🚀 Thank you for your contribution!
@imrajdas @ispeakc0de can you take a look here?
ispeakc0de
approved these changes
Aug 31, 2023
|
@Calvinaud gonna be released in a few moments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]