Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Logic for comma-separated splitting #564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chinmaym07
Copy link
Contributor

Signed-off-by: chinmaym07 [email protected]

What this PR does / why we need it:

Updated the logic for comma separated splitting.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #555

Special notes for your reviewer:

Checklist:

  • Fixes Logic for splitting comma-separated inputs need to be fixed #555
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

uditgaurav
uditgaurav previously approved these changes Sep 21, 2022
@chinmaym07
Copy link
Contributor Author

@ispeakc0de @uditgaurav @ksatchit Please review.

@ispeakc0de
Copy link
Member

Hi @chinmaym07, pre-checks action is failing. Please fix it
I saw you have added the strings.TrimSpace change in all chaoslibs. It have requested to change it only for your changes(splitting logic) not at all places

@neelanjan00
Copy link
Member

Hi @chinmaym07 , have you made all the changes suggested by Shubham?

@chinmaym07
Copy link
Contributor Author

Hi @neelanjan00 .
Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic for splitting comma-separated inputs need to be fixed
4 participants