Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Authentication Issues update Status Codes, password Policy, and add referer header #411

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kwx4957
Copy link

@kwx4957 kwx4957 commented Sep 4, 2024

Proposed changes

  • Expected response Status code 400 to 401 when user id and password is not correct
    graphql return status code
  • remove comma
  • new or reset Password are not working because password policy is changed
  • Add Request Header referer because graphql server check referer null
  • Add remoteHub field in the ChaosHub UI and API
  • Update expected error equal to conatin because aws documentDB return different error
assert expected 
AWS documentDB
write exception: write errors: [E11000 duplicate key error collection: chaosProbes index: name_1] to equal 

mongoDB
write exception: write errors: [E11000 duplicate key error collection: litmus.chaosProbes index: name_1 dup key: { name: "exp1111" }]

How has this been tested:

  • Test environment
    • GKE
    • AWS
    • local

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • [] I have added necessary documentation (if appropriate)
  • I have added Screenshots or Terminal snippets in the PR comment to validate the successful execution of changes

@kwx4957 kwx4957 changed the title Fix Authentication Issues Update Status Codes, Password Policy, and Add Referer Header Fix Authentication Issues update Status Codes, password Policy, and add referer header Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant