Skip to content

Add Cookie path check #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

timotei-litespeed
Copy link
Contributor

Based on this report https://wordpress.org/support/topic/fatal-error-in-litespeed-cache-setcookie-path-issue/
Added the code change from this PR.

@hi-hai
Copy link
Collaborator

hi-hai commented Feb 5, 2025

@timotei-litespeed this is not a valid fix. It will invalidate the func, defeat the setcookie.

You should locate the issue first. Figure out what char caused the error. As commented in the src code, // only set commenter status for current domain path this is the reason we set the cookie. So, should NOT bypass the path.

@timotei-litespeed timotei-litespeed marked this pull request as draft February 8, 2025 18:43
@Tymotey Tymotey force-pushed the Vary-fix_setcookie branch 2 times, most recently from c6eaaa5 to c8c719f Compare March 26, 2025 08:53
@Tymotey Tymotey force-pushed the Vary-fix_setcookie branch from ffd81b6 to 4752220 Compare March 26, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants