Fix build with older Apple Clang #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh oh, VS 2022 is indeed failing... CL-Jeremy@c926fac Edit: improved CI, now showing test details in results: https://ci.appveyor.com/project/-----/ls-qpack/builds/52013140 |
|
Calling for help with VS 2022. Those tests fail anyway regardless of this change… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build on older macOS (10.7-10.9): https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/303788
Sources:
This test should work for MSVC, where C17 support was added in VS 2019 v16.8 and must be turned on explicitly with switch
/std:c17(resulting definition:[[fallthrough]]). In other cases, this test should fall back to default case.