Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notification webhook and send of email #613

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NicolasMahe
Copy link
Member

This pull request involves the removal of several email notification templates and their related dependencies. The changes include deleting the email templates for various events, removing the corresponding imports and configurations, and updating the package.json file to remove unused dependencies.

Removal of email notification templates:

Updates to package.json:

  • Removed the @nft/webhook dependency.
  • Removed the nodemailer dependency.
  • Removed the @types/nodemailer dependency.

Changes to API:

  • pages/api/notification.ts: Removed the entire notification handling logic, including imports of email templates, configuration of the nodemailer transporter, and the map of email templates for different events.

Checklist

  • Base branch of the PR is dev

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
NicolasMahe Nicolas Mahe
@NicolasMahe NicolasMahe requested a review from antho1404 January 27, 2025 09:49
@NicolasMahe NicolasMahe self-assigned this Jan 27, 2025
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but make sure to cleanup the env/readme that probably contains these env/features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants