Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions src/agent/__tests__/config-loader.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,3 +340,74 @@ describe('editablePathPatterns', () => {
expect(cfg!.editablePathPatterns).toBeUndefined();
});
});

describe('maxBudgetUsd / maxTurns fallback', () => {
beforeEach(() => {
vi.resetModules();
mkdirSync(KNOWLEDGE_DIR, { recursive: true });
});

afterEach(() => {
rmSync(TEST_DIR, { recursive: true, force: true });
});

// Regression: agents without an explicit maxBudgetUsd/maxTurns previously fell
// back to hardcoded BUILTIN_DEFAULTS (5 / 100), ignoring CLAUDE_MAX_BUDGET_USD env.
// Triggered "Reached maximum budget ($5)" for pm agent in prod.
async function setupWithClaudeConfig(configObj: Record<string, unknown>, claudeOverrides: Record<string, unknown>) {
writeFileSync(CONFIG_FILE, JSON.stringify(configObj));
vi.stubEnv('AGENT_CONFIG_PATH', CONFIG_FILE);
vi.doMock('../../config.js', () => ({
config: {
agent: { configPath: CONFIG_FILE },
claude: { model: 'claude-sonnet-4-6', maxBudgetUsd: 5, maxTurns: 100, ...claudeOverrides },
},
}));
const loader = await import('../config-loader.js');
const result = loader.loadAgentConfig();
expect(result.loaded).toBe(true);
return loader;
}

it('should inherit maxBudgetUsd from config.claude when agent omits it', async () => {
await setupWithClaudeConfig(
{ agents: [{ id: 'pm' }] },
{ maxBudgetUsd: 50 },
);

const { agentRegistry } = await import('../registry.js');
const cfg = agentRegistry.get('pm');
expect(cfg!.maxBudgetUsd).toBe(50);
});

it('should inherit maxTurns from config.claude when agent omits it', async () => {
await setupWithClaudeConfig(
{ agents: [{ id: 'pm' }] },
{ maxTurns: 500 },
);

const { agentRegistry } = await import('../registry.js');
const cfg = agentRegistry.get('pm');
expect(cfg!.maxTurns).toBe(500);
});

it('should let file-level defaults override config.claude fallback', async () => {
await setupWithClaudeConfig(
{ defaults: { maxBudgetUsd: 20 }, agents: [{ id: 'pm' }] },
{ maxBudgetUsd: 50 },
);

const { agentRegistry } = await import('../registry.js');
expect(agentRegistry.get('pm')!.maxBudgetUsd).toBe(20);
});

it('should let agent-level value override both defaults and config.claude', async () => {
await setupWithClaudeConfig(
{ defaults: { maxBudgetUsd: 20 }, agents: [{ id: 'pm', maxBudgetUsd: 100 }] },
{ maxBudgetUsd: 50 },
);

const { agentRegistry } = await import('../registry.js');
expect(agentRegistry.get('pm')!.maxBudgetUsd).toBe(100);
});
});
4 changes: 2 additions & 2 deletions src/agent/config-loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ function mergeAgentConfig(input: AgentConfigInput, defaults: AgentDefaults): Age
toolPolicy,
readOnly,
settingSources: (input.settingSources ?? defaults.settingSources ?? BUILTIN_DEFAULTS.settingSources!) as ('user' | 'project')[],
maxBudgetUsd: input.maxBudgetUsd ?? defaults.maxBudgetUsd ?? BUILTIN_DEFAULTS.maxBudgetUsd!,
maxTurns: input.maxTurns ?? defaults.maxTurns ?? BUILTIN_DEFAULTS.maxTurns!,
maxBudgetUsd: input.maxBudgetUsd ?? defaults.maxBudgetUsd ?? config.claude.maxBudgetUsd,
maxTurns: input.maxTurns ?? defaults.maxTurns ?? config.claude.maxTurns,
requiresApproval: input.requiresApproval ?? defaults.requiresApproval ?? BUILTIN_DEFAULTS.requiresApproval!,
replyMode: input.replyMode ?? defaults.replyMode ?? BUILTIN_DEFAULTS.replyMode! as 'direct' | 'thread',
persona: input.persona ?? defaults.persona,
Expand Down
Loading