Skip to content

feat: add taptap-lookup skill - #153

Merged
lishuceo merged 1 commit into
mainfrom
feat/taptap-lookup-skill
Mar 17, 2026
Merged

feat: add taptap-lookup skill#153
lishuceo merged 1 commit into
mainfrom
feat/taptap-lookup-skill

Conversation

@lishuceo

Copy link
Copy Markdown
Owner

Summary

  • 新增 taptap-lookup skill,通过 TapTap App ID 查询对应的 Maker 项目映射信息
  • 调用 publisher-pd.spark.xd.com 公开 API,返回 project_id、maker_project_id、game_url 等
  • 同时安装到全局 ~/.claude/skills/ 目录,土豆儿也可使用

Test plan

  • 测试通过(56/57 files,已有的 quality.test.ts flaky 测试除外)
  • 验证 /taptap-lookup 820154 能正确返回项目信息

🤖 Generated with Claude Code

…pping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Mar 17, 2026

Copy link
Copy Markdown

Claude finished @lishuceo's task in 1m 1s —— View job


PR Review: taptap-lookup skill

  • Check for previous review comments — none found
  • Read changed files and gather context
  • Perform code review
  • Post review summary

Approved — Clean, well-structured skill addition.

Assessment

This PR adds a single SKILL.md file that instructs Claude how to look up TapTap App IDs via a public API. The skill follows the existing pattern (frontmatter with name, description, argument-hint), is clearly documented, and has a well-defined execution flow.

No issues found at confidence ≥ 75.

What looks good:

  • Correct skill frontmatter format, consistent with other skills in .claude/skills/
  • Clear step-by-step execution instructions with input parsing, API call, output formatting, and follow-up suggestions
  • API endpoint is hardcoded (no SSRF risk from user-controlled URLs)
  • Input is described as "纯数字" (pure digits), providing clear guidance for input handling

Minor note (below reporting threshold):

  • The skill could explicitly instruct to validate that the extracted app_id contains only digits before constructing the curl command, as a defense-in-depth measure. In practice, Claude handles this well given the "纯数字" instruction, so this is not a real concern.

@lishuceo
lishuceo merged commit 3f60176 into main Mar 17, 2026
4 checks passed
@lishuceo
lishuceo deleted the feat/taptap-lookup-skill branch March 17, 2026 04:26
lishuceo added a commit that referenced this pull request Apr 8, 2026
…pping (#153)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant