-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy the original transmission UI in the transmission-web-control mod #974
base: transmission-transmission-web-control
Are you sure you want to change the base?
Conversation
PR build pushed to |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey team, what needs to happen here? |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
mv /usr/share/transmission/public_html/index.html /usr/share/transmission/public_html/index.original.html | ||
cp -R /usr/share/transmission/public_html/* /themes/transmission-web-control/ | ||
mv /usr/share/transmission/public_html/index.original.html /usr/share/transmission/public_html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To minimise the risk of breakage now and in future it might be preferable to do this as:
cp /usr/share/transmission/public_html/index.html /themes/transmission-web-control/index.original.html
cp -nR /usr/share/transmission/public_html/* /themes/transmission-web-control/
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Description:
The
transmission-web-control
includes a link on the top-right to open the original Transmission UI, which is broken when using this mod. This is because when installing the theme using the install script provided by the theme developers, it renames the original UI asindex.original.html
- and keeps the other assets with the same name as they don't clash.Benefits of this PR and context:
Making the existing UI fully working, which involves being able to open the original UI under
index.original.html
as that's what the theme has a link to.How Has This Been Tested?
Created my fork repo and dockerhub, built the mod with the github actions and deployed locally. Confirmed the link now works.
https://github.com/edvincent/docker-mods/tree/transmission-transmission-web-control
https://hub.docker.com/layers/edouardv/mods/transmission-transmission-web-control/images/sha256-5c5ef6ac19fe6479928df777c571e5070d26471599e3c299ae90b097e21f2cc6?context=explore
Source / References: