-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce cron logging level by default and allow environment override #1012
Open
kenstir
wants to merge
36
commits into
linuxserver:master
Choose a base branch
from
kenstir:alpine-quieter-cron
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme and template updates
Replace Travis with GHA
Add information about GHCR
template update to s6 v2-v3 hybrid
add permission check workflow
switch to callable mod builder add issue-pr tracker workflow update permissions script update readme instructions
update template
remove s6v2 compatibility
add multi-arch support to template
Default MULTI_ARCH to true
template: fix casing to suppress docker build warning
Make cron logging configurable and quieter: * Support env var CRON_LOG_LEVEL, which is passed to the crond implementation * Default to being quieter and briefly explain rationale
693a590
to
9a15dcc
Compare
Sorry, I forgot to ask the team: If you agree with the rationale for this PR, then please create a branch |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Benefits of this PR and context:
Before this change, a linuxserver/qbittorrent:latest container run in Synology Container Manager would log multiple lines every minute. This made it hard to track down interesting and useful log messages.
Before:
After:
How Has This Been Tested?
DOCKER_MODS=docker.io/kenstir/alpine-quieter-cron:latest