Add early exit to xlet-settings if no instances exist, handle adding/removing xlets while xlet-settings is open. #13055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to handle adding and removing xlet while xlet-settings is open. - Arrows will be hidden if number of instances is less than 2 - Arrows will be shown if number of instances is greater than 1 - Next instance will be selected if currently selected xlet is removed - xlet-settings will exit if last instance of xlet is removed. - Corresponding setting pages are created/removed when xlets are created/removed
samw-26
force-pushed
the
add-remove-xlet-settings
branch
from
069df70 to
52f37b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xlet-settings now exits if command is run when no instances of an xlet exist.
Added logic to handle adding and removing xlet while xlet-settings is open.