workspace switcher: Add option to display window icons #12202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
anaximeno
force-pushed
the
workspace-switcher-add-display-icon-option
branch
2 times, most recently
from
c423b7d to
495be98
Compare
anaximeno
force-pushed
the
workspace-switcher-add-display-icon-option
branch
from
495be98 to
95d0f52
Compare
Member
|
Pretty cool idea but it needs some work and thoughts.
Marking as Next for now. |
clefebvre
changed the title
Contributor
Author
Sure I'll take a look at that, I can auto-hide the icon if the window area is smaller than the icon size in either of the directions. I'll test that, and see how it looks. |
clefebvre
changed the title
Contributor
Author
|
I converted the window icon size settings option into a combobox (to maintain consistency with other parts like how panel icon sizes are selected) and added an option (by default) to auto size the icons according to the workspace graph size:
|
This is handled after during button creation, and can lead to workspace switcher applet not following the focus windows initially.
|
Tested this on Mint 22.2 with Cinnamon 6.4.8, works like a charm. Thank you to the developer, would love to see it merged into master soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11455
ex. 1
ex. 2
Replaces #11530 (I closed and recreated this pull request with a cleaner commit log)