weather@mockturtl: Fix log spam, convert hourly summary into a tooltip. #7981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current method breaks .xsession-errors logging.
summary text a tooltip of the icon instead. The summary label was disabled in c57b274 but not completely removed, and was still throwing allocation warnings during updates. (cinnamon:177153): St-CRITICAL **: 16:17:23.909: st_widget_get_theme_node called on the widget [0x5a935feae560 StLabel.hourly-data ("...")] which is not in the stage. == Stack trace for context 0x5a935e0f5130 == ... ... ... ... This removes the unused actor entirely, along with all references to it, and adds a tooltip for the hourly icon that will display the weather summary on hover.
mtwebster
force-pushed
the
hourly-summary-tooltip
branch
from
8e2b2ad to
b3c1f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The summary label was disabled in c57b274 but not completely removed, and was still throwing allocation warnings during updates.
(cinnamon:177153): St-CRITICAL **: 16:17:23.909: st_widget_get_theme_node called on the widget [0x5a935feae560 StLabel.hourly-data ("...")] which is not in the stage.
== Stack trace for context 0x5a935e0f5130 ==
...
...
...
...
This removes the unused actor entirely, along with all references to it, and adds a tooltip for the hourly icon that will display the weather summary on hover.
edit: Gave up with the build, using the build.sh script, or simply
npx webpack, seems to ignore the es2017 in the tsconfig and wants to make a lot of compatibility changes (let/const -> var, etc...). Simply runningtscin the src/3.8 folder does not seem to do this (or would not, if the build didn't fail for other reasons).Since my changes were pretty isolated it was simple enough to pick just those for the commit here.
I don't really care about adding the summary as a tooltip, I just wanted to fix the log spam, and felt bad about simply discarding that info. This seemed a simple alternative.