Skip to content

fix: ScrollBar don't display when size is less #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Apr 1, 2025

it's consistent with dtkwidget.

pms: BUG-299771

Summary by Sourcery

Bug Fixes:

  • Ensure ScrollBar is only displayed when the content is scrollable (size is less than 1.0)

it's consistent with dtkwidget.

pms: BUG-299771
@18202781743 18202781743 requested review from mhduiy and BLumia April 1, 2025 04:00
Copy link

sourcery-ai bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

The pull request modifies the visibility logic of the scroll bar in ScrollBar.qml. The scroll bar will now only be visible if the control.policy is not T.ScrollBar.AlwaysOff AND the control.size is less than 1.0.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The scroll bar visibility logic was updated to ensure it's hidden when the control size is less than 1.0, in addition to the existing policy check.
  • Modified the visible property to include a condition that checks if control.size is less than 1.0.
qt6/src/qml/ScrollBar.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 代码修改增加了对 control.size 的检查,确保滚动条仅在 control.size 小于 1.0 时可见。

是否建议立即修改:

  • 否,这个修改看起来是有意为之,以避免在 control.size 非常小的情况下显示滚动条,这可能是一个合理的优化。但是,需要确保这个逻辑符合应用的整体设计,并且没有引入新的问题。如果 control.size 的值可能为 0 或负数,那么这个检查可能会在某些情况下导致滚动条始终不可见。建议添加对 control.size 的边界检查,确保其值在合理范围内。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Apr 1, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#478
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the size check was added.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 36f851d into linuxdeepin:master Apr 3, 2025
17 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Apr 3, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants