feat: allow skip including headers of annootations #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Nov 24, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
Decodetalkers
force-pushed
the
skipincludeannotations
branch
from
1689a9a to
b4ebb40
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Nov 24, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
|
commit message里面有typo |
Decodetalkers
force-pushed
the
skipincludeannotations
branch
from
b4ebb40 to
29123e8
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Nov 28, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
kegechen
pushed a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Nov 28, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
Decodetalkers
force-pushed
the
skipincludeannotations
branch
from
29123e8 to
9ac28fb
Compare
|
/+1 |
18202781743
reviewed
Dec 8, 2023
| for (const QString &annotation : annotations) { | ||
| if (annotation.indexOf('<') == -1) { | ||
| hs << "#include \"types/" << annotation.toLower() << ".h\"" << endl; | ||
| if (!skipIncludeAnnotations) { |
There was a problem hiding this comment.
看下面还有对annotations进行处理的逻辑，是不是需要一起跳过，
There was a problem hiding this comment.
下面是处理类型，这里需要跳过的是处理include,下面是原本没有fix的工具的逻辑
There was a problem hiding this comment.
include都跳过了，类型处理不跳过么？会不会出现类型不识别的问题，
There was a problem hiding this comment.
qt的工具是要求所有类型都放在-I的头文件的，我们为了方便把类型分开成各个头文件了
18202781743
previously approved these changes
Dec 8, 2023
zccrs
requested changes
Dec 11, 2023
cmake/DtkTools/DtkDBusMacros.cmake
Outdated
| @@ -33,6 +33,11 @@ function(dtk_add_dbus_interface _sources _interface _relativename) | |||
| set(_params -m) | |||
| endif() | |||
|
|
|||
| get_source_file_property(_skipincludeannotations ${_interface} SKIP_INCLUDEANNOTATIONS) | |||
Decodetalkers
force-pushed
the
skipincludeannotations
branch
2 times, most recently
from
6cc2e54 to
bd75921
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Dec 11, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Dec 11, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
|
如果想要应用新的workflow文件，需要重新force-push一下，等workflow准备好之后force-push一下吧 |
Decodetalkers
force-pushed
the
skipincludeannotations
branch
from
bd75921 to
0b6ad6c
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Dec 14, 2023
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#394
|
Doc Check bot |
|
@zccrs 已经改好了 |
zccrs
approved these changes
Dec 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Decodetalkers, zccrs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log:
Issue: linuxdeepin/dtk#147