Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP tmp #998

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP tmp #998

wants to merge 1 commit into from

Conversation

tsic404
Copy link
Contributor

@tsic404 tsic404 commented Dec 25, 2024

No description provided.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404 tsic404 marked this pull request as draft December 25, 2024 02:28
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt中新增了TreelandProtocols的依赖,需要确认是否所有相关的协议文件都已正确添加。
  • frame/CMakeLists.txt中新增了treeland-dde-shell-v1.xml的协议文件路径,需要检查该文件是否存在且路径正确。
  • qwaylandlayershellsurface.cpp中新增了resize函数,需要确保该函数的实现符合预期行为,并且已经通过了充分的测试。
  • qwaylandlayershellsurface_p.h中新增了DDEShellSurface类的声明,需要确认该类的实现是否正确,并且是否已经添加了必要的注释和文档。
  • dockpanel.cppdockpanel.h中新增了startSystemResize函数的声明和实现,需要确认该函数是否已经过充分的测试,并且是否与其他相关功能兼容。
  • main.qml中新增了startSystemResize的调用,需要确认该调用是否正确,并且不会对用户体验产生负面影响。

是否建议立即修改:

  • 确认新增的依赖和协议文件是否正确无误。
  • 检查resize函数的实现是否符合预期,并且已经通过了充分的测试。
  • 确认DDEShellSurface类的实现是否正确,并且已经添加了必要的注释和文档。
  • 确认startSystemResize函数的实现是否已经过充分的测试,并且与其他相关功能兼容。
  • 确认main.qml中的startSystemResize调用是否正确,并且不会对用户体验产生负面影响。

@tsic404 tsic404 changed the title tmp WIP tmp Dec 25, 2024
@tsic404 tsic404 force-pushed the panel/dock/resize branch 5 times, most recently from d37f344 to 93a0003 Compare December 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants