docs(changelog): version 0.4.0 [citest_skip]#107
Merged
spetrosi merged 1 commit intolinux-system-roles:mainfrom Mar 23, 2026
Merged
docs(changelog): version 0.4.0 [citest_skip]#107spetrosi merged 1 commit intolinux-system-roles:mainfrom
spetrosi merged 1 commit intolinux-system-roles:mainfrom
Conversation
Update changelog and .README.html for version 0.4.0 Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
Reviewer's GuideUpdate documentation for version 0.4.0 by expanding the README HTML with new Azure- and NVIDIA-related HPC variables and storage behavior, and by adding a detailed 0.4.0 entry to the changelog describing new features, bug fixes, and CI/testing updates. Flow diagram for storage management with rootvg rootlv usrlv varlv in hpc role v0.4.0 docsflowchart TD
A[hpc_manage_storage true] --> B[Identify root volume group hpc_rootvg_name]
B --> C[Ensure logical volume hpc_rootlv_name exists]
B --> D[Ensure logical volume hpc_usrlv_name exists]
B --> E[Ensure logical volume hpc_varlv_name exists]
C --> F[If LV size < hpc_rootlv_size then extend LV]
D --> G[If LV size < hpc_usrlv_size then extend LV]
E --> H[If LV size < hpc_varlv_size then extend LV]
F --> I[Mount hpc_rootlv_name at hpc_rootlv_mount]
G --> J[Mount hpc_usrlv_name at hpc_usrlv_mount]
H --> K[Mount hpc_varlv_name at hpc_varlv_mount]
A --> L[If Azure platform detected]
L --> M[Run growpart on backing partition]
M --> N[Run pvresize on PV]
N --> B
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 3 issues, and left some high level feedback:
- In the Storage section, the sentence "the role ensures that
rootlv,usrlvandvarlvin Azure has enough storage" should use the plural verb form ("have enough storage"). - The new
hpc_install_azurehpc_health_checkssection is marked up as an<h1>while most variable descriptions are<h2>; consider aligning its heading level with the surrounding variable sections for consistent structure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the Storage section, the sentence "the role ensures that `rootlv`, `usrlv` and `varlv` in Azure has enough storage" should use the plural verb form ("have enough storage").
- The new `hpc_install_azurehpc_health_checks` section is marked up as an `<h1>` while most variable descriptions are `<h2>`; consider aligning its heading level with the surrounding variable sections for consistent structure.
## Individual Comments
### Comment 1
<location path=".README.html" line_range="604-607" />
<code_context>
-<code>usrlv</code> in Azure has enough storage for packages to be
-installed. You can use variables described in this section to control
-the exact sizes and paths.</p>
+<p>By default, the role ensures that <code>rootlv</code>,
+<code>usrlv</code> and <code>varlv</code> in Azure has enough storage
+for packages to be installed. You can use variables described in this
+section to control the exact sizes and paths.</p>
</code_context>
<issue_to_address>
**nitpick (typo):** Subject-verb agreement issue in storage description sentence
`rootlv, usrlv and varlv in Azure has enough storage` uses a plural subject with a singular verb. Please change `has` to `have`, or rephrase along the lines of `the role ensures that the logical volumes rootlv, usrlv, and varlv in Azure have enough storage ...` for correct grammar.
```suggestion
<p>By default, the role ensures that the logical volumes <code>rootlv</code>,
<code>usrlv</code> and <code>varlv</code> in Azure have enough storage
for packages to be installed. You can use variables described in this
section to control the exact sizes and paths.</p>
```
</issue_to_address>
### Comment 2
<location path="CHANGELOG.md" line_range="42" />
<code_context>
+- fix: correct typo in service running test (#92)
+- fix: moneo test-script fixes (#95)
+- fix: install cuda-toolkit-config-common-12.9.79-1 with cuda-toolkit 12 (#97)
+- fix: install RDMA test script after azure specific resource path created (#98)
+- fix: add opt-in net.ifnames=0 for Azure images (#101)
+- fix: resolve nvidia-persistenced service failure issue on race condition (#102)
</code_context>
<issue_to_address>
**suggestion (typo):** Improve grammar and hyphenation for "azure specific" phrase
Consider rephrasing to "install RDMA test script after the Azure-specific resource path is created," or at least hyphenate "Azure-specific" to match standard usage and the other entries.
```suggestion
- fix: install RDMA test script after the Azure-specific resource path is created (#98)
```
</issue_to_address>
### Comment 3
<location path="CHANGELOG.md" line_range="68" />
<code_context>
+- ci: Ansible version must be string, not float [citest_skip] (#82)
+- test: add test script for aznfs package (#86)
+- ci: bump actions/upload-artifact from 6 to 7 (#88)
+- test: add testing Nvidia docker container script (#89)
+- test: add validation for hpc tuning (#93)
+- ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip] (#94)
</code_context>
<issue_to_address>
**suggestion (typo):** Align NVIDIA brand capitalization
Elsewhere in this changelog (e.g., "NVIDIA IMEX", "NVIDIA DCGM"), the brand is written as "NVIDIA". For consistency with the brand name and other entries, please change "Nvidia" here to "NVIDIA".
```suggestion
- test: add testing NVIDIA docker container script (#89)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+604
to
+607
| <p>By default, the role ensures that <code>rootlv</code>, | ||
| <code>usrlv</code> and <code>varlv</code> in Azure has enough storage | ||
| for packages to be installed. You can use variables described in this | ||
| section to control the exact sizes and paths.</p> |
There was a problem hiding this comment.
nitpick (typo): Subject-verb agreement issue in storage description sentence
rootlv, usrlv and varlv in Azure has enough storage uses a plural subject with a singular verb. Please change has to have, or rephrase along the lines of the role ensures that the logical volumes rootlv, usrlv, and varlv in Azure have enough storage ... for correct grammar.
Suggested change
| <p>By default, the role ensures that <code>rootlv</code>, | |
| <code>usrlv</code> and <code>varlv</code> in Azure has enough storage | |
| for packages to be installed. You can use variables described in this | |
| section to control the exact sizes and paths.</p> | |
| <p>By default, the role ensures that the logical volumes <code>rootlv</code>, | |
| <code>usrlv</code> and <code>varlv</code> in Azure have enough storage | |
| for packages to be installed. You can use variables described in this | |
| section to control the exact sizes and paths.</p> |
| - fix: correct typo in service running test (#92) | ||
| - fix: moneo test-script fixes (#95) | ||
| - fix: install cuda-toolkit-config-common-12.9.79-1 with cuda-toolkit 12 (#97) | ||
| - fix: install RDMA test script after azure specific resource path created (#98) |
There was a problem hiding this comment.
suggestion (typo): Improve grammar and hyphenation for "azure specific" phrase
Consider rephrasing to "install RDMA test script after the Azure-specific resource path is created," or at least hyphenate "Azure-specific" to match standard usage and the other entries.
Suggested change
| - fix: install RDMA test script after azure specific resource path created (#98) | |
| - fix: install RDMA test script after the Azure-specific resource path is created (#98) |
| - ci: Ansible version must be string, not float [citest_skip] (#82) | ||
| - test: add test script for aznfs package (#86) | ||
| - ci: bump actions/upload-artifact from 6 to 7 (#88) | ||
| - test: add testing Nvidia docker container script (#89) |
There was a problem hiding this comment.
suggestion (typo): Align NVIDIA brand capitalization
Elsewhere in this changelog (e.g., "NVIDIA IMEX", "NVIDIA DCGM"), the brand is written as "NVIDIA". For consistency with the brand name and other entries, please change "Nvidia" here to "NVIDIA".
Suggested change
| - test: add testing Nvidia docker container script (#89) | |
| - test: add testing NVIDIA docker container script (#89) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update changelog and .README.html for version 0.4.0
Signed-off-by: Sergei Petrosian spetrosi@redhat.com
Summary by Sourcery
Document new Azure- and NVIDIA-related capabilities and storage options in the HPC role and record the 0.4.0 release changes in the changelog.
Documentation: