test: remove redundant tuning tests from tests_skip_toolkit.yml

[dgchinner]

The tests_skip_toolkit.yml file is focused on testing custom storage configuration, but it also included tests verifying system tuning operations (limits.conf and sysctl settings). These tuning tests are unrelated to the storage configuration being tested and are redundant because:

1. The test disables hpc_tuning: false, so tuning shouldn't be applied anyway
2. There are separate dedicated test scripts for verifying tuning:
   • /opt/hpc/azure/tests/test-tuning.sh

The tuning verification tests in this file were:

• Checking /etc/security/limits.d/90-hpc-limits.conf for memlock/nofile/stack
• Checking sysctl settings for zone_reclaim_mode, neigh.gc_thresh*, and sunrpc.tcp_max_slot_table_entries

Changes:

• Remove "Print 90-hpc-limits.conf file" task
• Remove "Verify limits in 90-hpc-limits.conf" assertion task
• Remove "Verify sysctl settings set from templates" task
• Keep "Flush handlers" as it's necessary for proper cleanup

This makes the test file focused on its purpose (storage configuration) and removes confusion about why tuning tests exist when tuning is disabled.

Created-by-AI: Claude Sonnet 4.5

Prompt: new modification: the tests_skip_toolkit.yml file is testing custom storage configuration, but it also unconditionally tests whether unrelated system tuning operations have been done. We have separate scripts for testing the system tuning has been applied correct, so the checks in the tests... are redundant. Remove the redundant CI tests.

Issue Tracker Tickets (Jira or BZ if any): https://redhat.atlassian.net/browse/RHELHPC-188

Summary by Sourcery

Remove redundant tuning checks from the tests_skip_toolkit.yml scenario so it only validates custom storage behavior when toolkit tuning is disabled.

Tests:

• Drop limits.conf verification tasks from tests_skip_toolkit.yml that were redundantly checking ulimit-related tuning.
• Drop sysctl verification tasks from tests_skip_toolkit.yml that were redundantly checking kernel tuning parameters.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR narrows the scope of tests_skip_toolkit.yml so it only validates custom storage configuration behavior when hpc_tuning is disabled, by removing redundant system tuning checks (limits.conf and sysctl) while preserving handler flushing and cleanup behavior.

File-Level Changes

Change	Details	Files
Remove redundant tuning verification tasks from the skip_toolkit test playbook so it no longer asserts limits.conf and sysctl tuning when hpc_tuning is disabled.	Delete the task that cats /etc/security/limits.d/90-hpc-limits.conf and registers its contents for later assertions. Delete the assertion task that validates memlock, nofile, and stack limits in 90-hpc-limits.conf based on the captured file content. Delete the sysctl verification task that loops over vm.zone_reclaim_mode, neigh.gc_thresh*, and sunrpc.tcp_max_slot_table_entries and asserts their values via sysctl -n. Keep the surrounding handler flush and cleanup logic unchanged so storage configuration tests and teardown still run as before.	tests/tests_skip_toolkit.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since this playbook is explicitly about testing behavior with hpc_tuning: false, consider adding a simple assertion that tuning artifacts (e.g. limits/sysctl files or settings) are not present or applied, to make the intent of the scenario explicit and guard against regressions where tuning is accidentally enabled.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since this playbook is explicitly about testing behavior with `hpc_tuning: false`, consider adding a simple assertion that tuning artifacts (e.g. limits/sysctl files or settings) are *not* present or applied, to make the intent of the scenario explicit and guard against regressions where tuning is accidentally enabled.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}