Skip to content

Conversation

a-wai
Copy link
Contributor

@a-wai a-wai commented Aug 28, 2024

While postmarketOS makes use of a kernel cmdline argument, this isn't the case for all distros. Furthermore, this argument isn't present in those added automatically by the Android bootloader.

In order to still be able to use qbootctl on other distros, this change ensures we use the currently active slot as the current slot when the cmdline argument is missing. This ensure qbootctl -m picks up the correct slot more often than not, instead of always defaulting to _a.

@kcxt
Copy link
Member

kcxt commented Feb 11, 2025

Sorry i totally missed this PR!

Not sure how motivated you are still with this, the diff needs fixing (is it necessary to move the function?) and I think it would make sense to adjust the function name to reflect the fallback behaviour.

I can also make these changes while merging given the timespan...

@a-wai
Copy link
Contributor Author

a-wai commented Feb 12, 2025

is it necessary to move the function?

Well it has to know about get_active_boot_slot(), defined on L541. The alternative being a forward declaration of the latter, I'm fine with either solution.

and I think it would make sense to adjust the function name to reflect the fallback behaviour.

Sure, do you have something specific in mind? get_current_or_active_slot? get_current_from_cmdline_or_active?

@kcxt
Copy link
Member

kcxt commented Mar 18, 2025

OK I'm not sure what the heck I did here, github just wouldn't let me push to the PR. I adjusted this slightly and pushed it to main in 413ee35

@rmuxnet
Copy link

rmuxnet commented Mar 18, 2025

OK I'm not sure what the heck I did here, github just wouldn't let me push to the PR. I adjusted this slightly and pushed it to main in 413ee35

Btw is this supposed to technically fix the soft bricking issue if using any other distro apart pmos as in pmos it works fine as in arch ir corrupts lun and gpt tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants