Skip to content

Service ip reservation #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 71 commits into from
Closed

Service ip reservation #457

wants to merge 71 commits into from

Conversation

hcwagner
Copy link
Contributor

@hcwagner hcwagner commented Sep 9, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

hcwagner and others added 30 commits June 26, 2025 10:36
@hcwagner
add annotation for Service reserved IP
9ee7e80
@hcwagner
Add creation/update handling for Service LB reserved IP annotation
bdf6111
use hcwagner/linodego branch
8d02d56
add full net package for IP addr checks
03fa17b
@Andrews2024
Added subnet-names flag and condition that vpc-names be set
c4acefe
cleanup bad merge
2376960
update replacement branch with latest linodego rebase
d226004
@jpalagir
Add testcases for reserved IP support to CCM
84b7103
@jpalagir
Test fails when curl command is ran against the service ip. Added sle…
d65394c 
…ep delay for the service to come up
@jpalagir
Added firewall in lb-created-with-reserved-ip-linode-range and lb-cre…
7e33f6e 
…ated-with-reserved-ip-nb-range testcases. Removed the liveness check in lb-created-with-specified-nb-id-reserved and lb-created-with-reserved-ip-and-nb-id-annotations.
@jpalagir
Retrieve kubeclient if missing in createIPChangeWarningEvent
384be67
@jpalagir
Modified REGION to LINODE_REGION
a93deae
update to linodego 1.55.0
01379d7
@hcwagner
Merge branch 'main' into service-ip-reservation
e20dcb3
update deps
60aef60
correct formatting for go fmt/vet
800345b
use linodego branch with VPC/IP Reservation support
46bc86b
update error reporting to satisfy linter
aee6a78
@jpalagir
Change the frirewall name to avoid character limit
78c3c60
@jpalagir
Firewall label update
2d799df
add initial unit tests and mocks
760005f
add reserve IP fake API endpoint
d2d4001
cleanup event naming
d77f4a1
add unit test for reserved IP LB creation/update
8674bc2
remove unnecessary validation checks
ded70ce
@jpalagir
Move the cleanup o c leanup section
64c91e2
@jpalagir
Invalid IP event generation message updated. Removed unnecessary echo…
1e9010e 
… statements
cleanup tests for linter
044cd6d
add timestamp to event object
936f5db
@AshleyDumaine
massive refactor to deal with cyclic imports if we want to use the in…
2d46e2e 
…stance cache in the node IPAM controller
hcwagner and others added 27 commits August 25, 2025 10:56
@hcwagner
Add creation/update handling for Service LB reserved IP annotation
5fc986f
use hcwagner/linodego branch
31d8260
add full net package for IP addr checks
fb353df
@Andrews2024
Added subnet-names flag and condition that vpc-names be set
42c5d8c
cleanup bad merge
5bbc460
update replacement branch with latest linodego rebase
193ff9f
@jpalagir
Add testcases for reserved IP support to CCM
cda7a4d
@jpalagir
Test fails when curl command is ran against the service ip. Added sle…
4917e8a 
…ep delay for the service to come up
@jpalagir
Added firewall in lb-created-with-reserved-ip-linode-range and lb-cre…
28f60a3 
…ated-with-reserved-ip-nb-range testcases. Removed the liveness check in lb-created-with-specified-nb-id-reserved and lb-created-with-reserved-ip-and-nb-id-annotations.
@jpalagir
Retrieve kubeclient if missing in createIPChangeWarningEvent
c13ec61
@jpalagir
Modified REGION to LINODE_REGION
7080fa5
update to linodego 1.55.0
78c2b0b
correct formatting for go fmt/vet
82cdd4c
update error reporting to satisfy linter
51384ee
@jpalagir
Change the frirewall name to avoid character limit
684e7c6
@jpalagir
Firewall label update
83066f2
add initial unit tests and mocks
66bb588
add reserve IP fake API endpoint
83e6c6d
cleanup event naming
b1021f4
add unit test for reserved IP LB creation/update
24a5276
remove unnecessary validation checks
2cb8d57
@jpalagir
Move the cleanup o c leanup section
a83e2c8
@jpalagir
Invalid IP event generation message updated. Removed unnecessary echo…
20afa65 
… statements
cleanup tests for linter
f8785bf
add timestamp to event object
e36dac6
@hcwagner
Merge branch 'linode:service-ip-reservation' into service-ip-reservation
70913af
@jpalagir
Delete teh nb created through API call
35ad816
@hcwagner hcwagner closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hcwagner @Andrews2024 @jpalagir @AshleyDumaine @komer3