[feat] Add IP Reservation support for Services backed by NodeBalancers #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep delay for the service to come up
…ated-with-reserved-ip-nb-range testcases. Removed the liveness check in lb-created-with-specified-nb-id-reserved and lb-created-with-reserved-ip-and-nb-id-annotations.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
+ Coverage 71.88% 72.06% +0.17%
==========================================
Files 19 19
Lines 3625 3658 +33
==========================================
+ Hits 2606 2636 +30
- Misses 779 781 +2
- Partials 240 241 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
komer3
reviewed
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on adding support for IP Reservation while using NodeBalancers as a Service LoadBalancer. This assume that the customer has:
Reserved an IP through Linode CLI, CM, terraform, etc.
Supplies the reserved IP attached to their account through the provided Annotation