-
Notifications
You must be signed in to change notification settings - Fork 91
Add support for Helmfile #141
base: master
Are you sure you want to change the base?
Conversation
Helmfile command is settable. Upgraded helmfile version. Params under helmfile. Prefixed helmfile specific variables for clarity. Fixed early execution of helmfile. Improved Dockerfile to add plugins before file assets to speed up build. Switch back to alpine Helm release and downgrade for better compatibility. Remove bash debugging flag. Fixed hardcoded references to helm when they should be using the helm_bin variable.
Hey, thanks so much! What are your thoughts about that? |
I agree that in some ways it should be split, but there was so much in common it was easy to add without too much extra code. Also, Helmfile with Concourse is a much better solution than directly calling Helm. Much of the Concourse configuration can be simplified into a simpler helmfile. Something for you to ponder, maybe others may share feedback. |
@@ -1,17 +1,21 @@ | |||
FROM linkyard/alpine-helm:2.16.6 | |||
FROM alpine/helm:2.14.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason why you want to downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but the image location should go back to alpine/helm. Version is painful before can't use new Helm clients with older server versions. Can't really win for that unfortunately and would make sense to go to the latest Helm 2 release.
Implemented helmfile support. Improvements have been added to the original work from https://github.com/QuoineFinancial/concourse-helmfile-resource.
Extra functionality or fixes:
Other improvements unrelated to Helmfile support:
Have concerns about the meaning of the result as it is specific to a helm release and a helmfile can have many releases in it. Have not changed this logic and it continues to work as originally designed.